Cherry-picks for 2.10.26-RC.4 #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Fixes: #6496 Signed-off-by: Yevhen Surovskyi <surovskyi.y@ajax.systems>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
If the same queue group has members running on different leafnodes connected through a gateway, it was possible for a message to be delivered to several members running on different leaf nodes if there was an interest (either plain subscription or for other queue groups) that made the produce message travel through the gateway. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Partial backport of #6140 for v2.10.26+ `mset.ackMsg` could fail if the clustered stream is behind on applies on this server, but the consumer's ack floor is ahead. In this case `checkStateForInterestStream` would skip its check floor ahead, never retrying to ack/remove this message again. Which would leave messages around, not being removed even though they could be. This PR is a partial backport, still doing `mset.ackMsg` for each individual server instead of via message delete proposals for clustered streams, but allowing to retry if a removal should be done. Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Maurice van Veen <github@mauricevanveen.com> Signed-off-by: Neil Twigg <neil@nats.io> Co-authored-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
Signed-off-by: Neil Twigg neil@nats.io