stree: Split Iter into IterFast and IterOrdered
#6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/streeiter
branch
from
99a9a36 to
b42a5b5
Compare
derekcollison
requested changes
Feb 5, 2025
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/streeiter
branch
from
b42a5b5 to
aa8a594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of the
Iter()call-sites required ordering, and ordering would slow down the process quite a bit, so replace with two newIterFast()andIterOrdered()functions instead.This should speed up populating the per-subject infos, multi-filter num pending and enforcing the per-subject limits.
Signed-off-by: Neil Twigg neil@nats.io