Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake TestJetStreamClusterPreserveWALDuringCatchupWithMatchingTerm #6417

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

MauriceVanVeen
Copy link
Member

Previously the test could fail if it so happened that a heartbeat was sent either before or during the storeToWAL loop, due to directly interacting with the RAFT code.

To de-flake, instead publish some messages and manually truncate one replica in a way which the RAFT layer can/should always recognize and fix.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner January 28, 2025 09:52
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 67aa107 into main Jan 28, 2025
5 checks passed
@derekcollison derekcollison deleted the maurice/deflake-preserve-wal branch January 28, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants