De-flake TestJetStreamClusterRedeliverBackoffs #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
pushed a commit
that referenced
this pull request
Jan 9, 2025
`TestJetStreamClusterRedeliverBackoffs` would sometimes fail, even though it would be very close to the intended backoff: ``` jetstream_cluster_2_test.go:4216: Timing is off for 1, expected ~100ms, but got 99.846642ms jetstream_cluster_2_test.go:4216: Timing is off for 0, expected ~25ms, but got 50.767748ms jetstream_cluster_2_test.go:4216: Timing is off for 4, expected ~250ms, but got 249.95211ms ``` Allowing for a bit of leeway on both ends. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestJetStreamClusterRedeliverBackoffswould sometimes fail, even though it would be very close to the intended backoff:Allowing for a bit of leeway on both ends.
Signed-off-by: Maurice van Veen github@mauricevanveen.com