Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] JetStream would exceed limits calculation #6264

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

MauriceVanVeen
Copy link
Member

The calculation should check if the current total plus what we want to store exceeds the max.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 16, 2024 14:01
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 7bd91dc into main Dec 16, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/js-exceed-limits-calc branch December 16, 2024 14:26
neilalexander added a commit that referenced this pull request Dec 16, 2024
Includes the following:

- #6260
- #6249
- #6264
- #6265
- #6266

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants