Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] MaxMsgsPerSubject limit not applied when updating from no value #6244

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[FIXED] MaxMsgsPerSubject limit not applied when updating from no value #6244

merged 1 commit into from
Dec 12, 2024

Conversation

MauriceVanVeen
Copy link
Member

If a stream, either in-memory or file-based, would be updated from having no MaxMsgsPer to having it set the messages would not be removed.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
[FIXED] MaxMsgsPerSubject limit not applied when updating from no value
e659de1 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 11, 2024 15:53
wallyqs
wallyqs approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekcollison
derekcollison approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit cee58f7 into main Dec 12, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/max-msgs-per-update branch December 12, 2024 00:34
@neilalexander neilalexander mentioned this pull request Dec 13, 2024
Merged
neilalexander added a commit that referenced this pull request Dec 13, 2024
@neilalexander
Cherry-picks for 2.10.24-RC.1 (#6251)
64392c2 
Includes the following:

- #6226
- #6232
- #6235
- #6064
- #6244
- #6246
- #6247
- #6248
- #6250

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauriceVanVeen @wallyqs @derekcollison