Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include unnecessary ClientInfo fields in metalayer snapshots #6185

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Don't include unnecessary ClientInfo fields in metalayer snapshots #6185

merged 1 commit into from
Nov 27, 2024

Conversation

neilalexander
Copy link
Member

This should reduce the size of metalayer snapshots quite significantly by only including the Account, Service and Cluster fields from the ClientInfo, as those are the only ones that are relevant from a snapshot.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander
Don't include unnecessary ClientInfo fields in stream and consumer …
2b3a6e6 
…assignments

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner November 27, 2024 16:26
wallyqs
wallyqs approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander changed the title Don't include unnecessary ClientInfo fields in stream and consumer assignments Don't include unnecessary ClientInfo fields in metalayer snapshots Nov 27, 2024
derekcollison
derekcollison reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Should we also remove from internal memory once the api response has been sent?

@neilalexander
Copy link
Member Author

I can take a look but would rather do so in a separate PR to separate risks.

@derekcollison derekcollison self-requested a review November 27, 2024 16:53
derekcollison
derekcollison approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit cfaad68 into main Nov 27, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/snapclientinfo branch November 27, 2024 16:54
@neilalexander neilalexander mentioned this pull request Nov 27, 2024
Merged
neilalexander added a commit that referenced this pull request Nov 27, 2024
@neilalexander
Cherry-picks for 2.10.23-RC.7 (#6186)
a4453aa 
Includes the following:

- #6183
- #6185

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilalexander @wallyqs @derekcollison