Refactor duplicate Nats-Msg-Id tracking
#6174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
neilalexander
force-pushed
the
neil/dedupe
branch
from
5bf06fe to
5edadf8
Compare
neilalexander
force-pushed
the
neil/dedupe
branch
2 times, most recently
from
146c96c to
7c25f10
Compare
|
Want me to take a look? |
|
Yes please. I did take a look at |
neilalexander
force-pushed
the
neil/dedupe
branch
from
7c25f10 to
2ccbf43
Compare
* Swap out `ddmap` for stree (better message ID deduplication, consistent lookup times) * Remove `ddarr` and `ddindex`, replace with linked list tracking * Add unit test to prove the correct behaviour Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/dedupe
branch
from
2ccbf43 to
b7fa8cf
Compare
neilalexander
added a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current duplicate tracking has a couple of problems, namely that the
ddmapcapacity is potentially never reclaimed if it grows suddenly, and secondly that we have to constantly monitorddarr's capacity and copy it to stop the array from growing infinitely too.This PR makes the following changes:
ddmapis now using the stree, which means there is efficient in-place deduplication of message IDs and no infinitely growing backing capacity;ddarrandddindexare now gone, replaced with linked-list references andddnextandddlasttracking, so we also don't need to watch the capacity and reallocate this either;ddtmris now only scheduled when there is actually something to do.Also added a unit test to prove the behaviour as well as the linked-list stitching.
Signed-off-by: Neil Twigg neil@nats.io