Change Consumer Priority Group State info and fix pinned TTL #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were storing just the pinned IDs, but to be more future-proof, this commit will switch approach to store a struct. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Until now, we were resetting Pinned TTL only if pin was set on incoming Pull Request, but not when we were pinning an existing waiting request. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
|
Let me know if you want to hold on merge til @ripienaar and/or @jnmoyne have a chance to review as well. |
|
Reviewed and tested the changes and they LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces few changes & improvements to Pinned Consumers
Fix pinned TTL timer when its assigned from existing waiting request
Until now, we were resetting Pinned TTL only if pin was set on incoming
Pull Request, but not when we were pinning an existing waiting request.
It also simplifies some logic.
Switch to slice of PriorityGroupState
Previously, we were storing just the pinned IDs, but to be more
future-proof, this commit will switch approach to store a struct.
It also adds
PinnedTSwhich can be useful for debugging pinned consumers.cc @ripienaar @jnmoyne
Signed-off-by: Tomasz Pietrek tomasz@nats.io