Fix desync after errCatchupAbortedNoLeader #5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauriceVanVeen
commented
Oct 10, 2024
mprimi
reviewed
Oct 10, 2024
MauriceVanVeen
force-pushed
the
maurice/desync-after-catchup-no-leader
branch
from
d421d9b to
c391623
Compare
Yes 🙂 |
mprimi
reviewed
Oct 11, 2024
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/desync-after-catchup-no-leader
branch
from
c391623 to
bf69ce9
Compare
|
LMK when this is good to go for review. |
Awaiting CI to be green, but otherwise good for review |
neilalexander
added a commit
that referenced
this pull request
Oct 16, 2024
derekcollison
added a commit
that referenced
this pull request
Oct 29, 2024
With the introduction of these PRs, #5939 and #5986, we don't blow away our state anymore as we can keep retrying. However, if a follower had installed a snapshot from the leader and would then start processing it, only for the leader to go offline for an extended period, we could spin. Since we'd immediately detect there's no leader, stop the RAFT group, recreate it, stop since no leader, etc. etc. Prevent spinning by introducing some wait time in-between if it's the first time trying, and check before returning if a leader became available since as then we could still continue. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a related case of RAFT state being deleted was fixed, when running into
errCatchupTooManyRetries: #5939After hitting this we shutdown and retry.. but if we have not elected a leader yet we'd hit
"catchup for stream '%s > %s' aborted, no leader", which then would again throw away RAFT state. This PR proposes a fix for that case.Signed-off-by: Maurice van Veen github@mauricevanveen.com