[FIXED] LeafNode: Don't report cluster name in varz/banner when none defined #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined. In situation where a Leaf server has no cluster specified, we internally use the server name as the cluster name. We may need it in the protocol so that the hub can suppress some messages to avoid duplicates. We were however still reporting a cluster name in `/varz` and in the banner on startup. This PR fixes both. Resolves #5913 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@ripienaar I wonder if this could have an adverse effect on NATS monitoring tooling. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situation where a Leaf server has no cluster specified, we internally use the server name as the cluster name. We may need it in the protocol so that the hub can suppress some messages to avoid duplicates.
We were however still reporting a cluster name in
/varzand in the banner on startup. This PR fixes both.Resolves #5913
Signed-off-by: Ivan Kozlovic ivan@synadia.com