Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake tests #5765

Merged
merged 5 commits into from
Aug 8, 2024
Merged

De-flake tests #5765

merged 5 commits into from
Aug 8, 2024

Conversation

neilalexander
Copy link
Member

This PR tries to deflake some unit tests.

Signed-off-by: Neil Twigg neil@nats.io

The on-disk state seemed to be inconsistent with truncation but removing
the `msgs` folder seems to resolve the issue in local testing.

Signed-off-by: Neil Twigg <neil@nats.io>
Wait for acks to replicate.

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
…ceResetAfterRestart` and `TestNoRaceJetStreamClusterMemoryWorkQueueLastSequenceResetAfterRestart`

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner August 8, 2024 13:21
server/tav.idx Outdated Show resolved Hide resolved
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit e9ee2a0 into main Aug 8, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/catchupnostate branch August 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants