Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jsz limits optional #5686

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

ripienaar
Copy link
Contributor

To create tooling and to be able to detect
when ran against old NATS Servers it would
be better if this was a pointer so the absense
of it would indicate unsupported servers rather
than ones that support this feature but have
no limits set

Signed-off-by: R.I.Pienaar rip@devco.net

To create tooling and to be able to detect
when ran against old NATS Servers it would
be better if this was a pointer so the absense
of it would indicate unsupported servers rather
than ones that support this feature but have
no limits set

Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar ripienaar requested a review from a team as a code owner July 23, 2024 08:10
@ripienaar
Copy link
Contributor Author

Sorry @derekcollison tried to add support to CLI for the PR #5652 and I realised I screwed up so small follow up here

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 5857a63 into nats-io:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants