Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Fix imports not being available for a client sometimes after a server restart #5589

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jun 25, 2024

When a client would reconnect to a server that was still setting up the imports and exports a client that reconnected too soon to a server that had just been restarted might be missing some of the imports that were defined in its JWT.

Fixes #5480

wallyqs and others added 2 commits June 24, 2024 03:25
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…5588)

With this change we do not need lookup from tmpAccounts on import
processing.
Needed to fix data races from same tmpAccount entry now be re-used.

Signed-off-by: Derek Collison <derek@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner June 25, 2024 04:51
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 304cfc8 into main Jun 25, 2024
3 checks passed
@derekcollison derekcollison deleted the imports-reconnect branch June 25, 2024 05:05
wallyqs added a commit that referenced this pull request Jun 25, 2024
… restart (#5589)

When a client would reconnect to a server that was still setting up the
imports and exports a client that reconnected too soon to a server that
had just been restarted might be missing some of the imports that were
defined in its JWT.

---------

Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Co-authored-by: Derek Collison <derek@nats.io>
@wallyqs wallyqs changed the title Fix imports not being available for a client sometimes after a server restart [FIXED] Fix imports not being available for a client sometimes after a server restart Jun 25, 2024
neilalexander pushed a commit that referenced this pull request Jun 25, 2024
… restart (#5589)

When a client would reconnect to a server that was still setting up the
imports and exports a client that reconnected too soon to a server that
had just been restarted might be missing some of the imports that were
defined in its JWT.

---------

Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Co-authored-by: Derek Collison <derek@nats.io>
wallyqs added a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topic import/export can cause dropped messages for an account
2 participants