-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update GitHub actions #4720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we appreciate the contribution @reneleonhardt! A couple questions, but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wallyqs Looks like this workflow was explicitly disabled a month ago, so it appears safe to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this file post-PR. Don't want to block this one.
@@ -0,0 +1,10 @@ | |||
version: 2 | |||
updates: | |||
- package-ecosystem: "gomod" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependabot docs don't give much insight, but I am going to assume this does not attempt to automatically propose new Go versions, only the dependency updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know only dependencies and not a major golang upgrade... but even if such a PR would be created you wouldn't have to merge it 😉
I totally agree on the docs though, real life questions and examples would be helpful indeed 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure and agreed 😄
Also bumped default tag for nightly.
Signed-off-by: Rene Leonhardt 65483435+reneleonhardt@users.noreply.github.com