[IMPROVED] Routing: upgrade non solicited routes if present in config #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a server accepts a route, that route would not be marked as solicited or configured while it should if it was present in the configuration. Prior to pooling, if server A pointed to server B and vice-versa, one of the server will have the route as solicited and the server that accepted the route would have upgraded it as solicited. With pooling code, this was not always happening. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
route_solicit_upgrade
branch
from
2a4b44e to
cd36ecc
Compare
When processing an implicit route INFO protocol, we can detect if we already have this route configured. The function to do so could return false if the remote's cluster's listen specification did not provide an IP address (would default to 0.0.0.0). Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
approved these changes
Oct 25, 2023
kozlovic
added a commit
that referenced
this pull request
Oct 25, 2023
Need to handle case of no pooling or pool size of 1. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
added a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server accepts a route, that route would not be marked as solicited or configured while it should if it was present in the configuration.
Prior to pooling, if server A pointed to server B and vice-versa, one of the server will have the route as solicited and the server that accepted the route would have upgraded it as solicited. With pooling code, this was not always happening.
Maybe related to #4681
Signed-off-by: Ivan Kozlovic ivan@synadia.com