Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic account behaviors. #2840

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Remove dynamic account behaviors. #2840

merged 1 commit into from
Feb 4, 2022

Conversation

derekcollison
Copy link
Member

We used these in tests and for experimenting with sandboxed environments like the demo network.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although code could be simplified a bit by removing expire...

server/route.go Outdated Show resolved Hide resolved
We used these in tests and for experimenting with sandboxed environments like the demo network.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 664e8b9 into main Feb 4, 2022
@derekcollison derekcollison deleted the dyn_acc branch February 4, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants