Store JetStream Config in node info map #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't update the JetStream configuration in
Server.nodeToInfo. This can cause a problem if the user doesn't explicitly configure JetStreamMaxStoreorMaxMem. It's a problem because some code expectsMaxStore=-1to be resolved to a real non-negative amount of bytes. Specifically, this check fails: https://github.com/nats-io/nats-server/blob/main/server/jetstream_cluster.go#L3683This is what the call stack looks like.
jetStreamCluster.selectPeerGroup- returns nil becauseni.cfg.MaxStore > int64(used)is false becauseMaxStore=-1jetStream.createGroupForStream- returns nil becauseselectPeerGroupreturned nilServer.jsClusteredStreamRequest- returns "insufficient resources"The included test fails to
js.AddStreamwith the error "insufficient resources" on the main branch, but passes on this branch.