Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly: set Go version to 1.17 and use latest goreleaser #2823

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

kozlovic
Copy link
Member

[ci skip]

Signed-off-by: Ivan Kozlovic ivan@synadia.com

[ci skip]

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic
Copy link
Member Author

I have verified in running the Nightly from this branch that it now uses Go 1.17:

Digest: sha256:8af6d1d79ebdc5e78426a38bacafce18cf5f2100733120bb197731e8ad77e2ab
Status: Downloaded newer image for synadia/nats-server:nightly
[1] 2022/01/26 22:33:07.476297 [INF] Starting nats-server
[1] 2022/01/26 22:33:07.476350 [INF]   Version:  2.7.1
[1] 2022/01/26 22:33:07.476353 [INF]   Git:      [609a9ba2]
[1] 2022/01/26 22:33:07.476354 [DBG]   Go build: go1.17.6
[1] 2022/01/26 22:33:07.476358 [INF]   Name:     NBIAUX6WE2Y7QFCBJ4NXEOHLPJ44FQI4MPY6QAPSFIOQC77ONG2CYJ5A
[1] 2022/01/26 22:33:07.476363 [INF]   ID:       NBIAUX6WE2Y7QFCBJ4NXEOHLPJ44FQI4MPY6QAPSFIOQC77ONG2CYJ5A
[1] 2022/01/26 22:33:07.476419 [DBG] Created system account: "$SYS"
[1] 2022/01/26 22:33:07.476910 [INF] Listening for client connections on 0.0.0.0:4222
[1] 2022/01/26 22:33:07.476954 [DBG] Get non local IPs for "0.0.0.0"
[1] 2022/01/26 22:33:07.477292 [DBG]   ip=172.17.0.2
[1] 2022/01/26 22:33:07.477333 [INF] Server is ready

After this is merged, I will trigger the build again.

Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do recall a reason for pinning to that goreleaser but let’s see I guess. Don’t remember details.

@kozlovic
Copy link
Member Author

@ripienaar It was because that was the last release to support vendor. I did release NATS Server with the latest goreleaser and it works. Also, I tried the nightly from this branch, and as you can see it works.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 26b692e into main Jan 26, 2022
@kozlovic kozlovic deleted the fix_nightly_2 branch January 26, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants