Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added active servers to statsz. #2276

Merged
merged 4 commits into from
Jun 10, 2021
Merged

Added active servers to statsz. #2276

merged 4 commits into from
Jun 10, 2021

Conversation

derekcollison
Copy link
Member

This is generally useful but will also help with cli actions since we know from first response how many total responses are expected.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

This is generally useful but will also help with cli actions since we know from first response how many total responses are expected.

Signed-off-by: Derek Collison <derek@nats.io>
@ripienaar
Copy link
Contributor

LGTM, didnt check how this is maintained - like how accurate it is and on what time frame but will help with hints

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison
Copy link
Member Author

If the servers shutdown and that message is received the server is removed, otherwise we will remove it when we sweep for lost remotes, iirc 2mins.

Copy link
Contributor

@matthiashanel matthiashanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison merged commit 00bfc1f into master Jun 10, 2021
@derekcollison derekcollison deleted the active_servers branch June 10, 2021 18:01
bwerthmann added a commit to bwerthmann/nats-surveyor that referenced this pull request Dec 15, 2021
Pull all dependencies with 'go get -u'.

nats-server v2.3.0 added new fields to 'server.ServerStats'

    ActiveServers    int            `json:"active_servers,omitempty"`
    JetStream        *JetStreamVarz `json:"jetstream,omitempty"`

Related PRs:

* JetStream: nats-io/nats-server#2269
* ActiveServers: nats-io/nats-server#2276

Signed-off-by: Ben Werthmann <ben@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants