-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server_name
with Space characters breaks reply routing for leaf nodes.
#5633
Labels
defect
Suspected defect such as a bug or regression
Comments
I think throwing validation error would be a better solution here, as spaces are troublesome, especially in NATS context. |
kozlovic
added a commit
that referenced
this issue
Jul 19, 2024
Having cluster name with spaces in the context of a leaf node could cause problems when a subscription on the leaf node would be propagated in the cluster's hub. Since when a gateway is specified the name of the gateway needs to match the name of the cluster, the restriction of "no spaces" is added to gateway name. Finally, in the case of the leafnode, if no cluster name is specified the server name is used, so also applying the restriction to the server name. Resolves #5633 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
added a commit
that referenced
this issue
Jul 19, 2024
Having cluster name with spaces in the context of a leaf node could cause problems when a subscription on the leaf node would be propagated in the cluster's hub. Since when a gateway is specified the name of the gateway needs to match the name of the cluster, the restriction of "no spaces" is added to gateway name. Finally, in the case of the leafnode, if no cluster name is specified the server name is used, so also applying the restriction to the server name. Resolves #5633 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
wallyqs
pushed a commit
that referenced
this issue
Jul 19, 2024
Having cluster name with spaces in the context of a leaf node could cause problems when a subscription on the leaf node would be propagated in the cluster's hub. Since when a gateway is specified the name of the gateway needs to match the name of the cluster, the restriction of "no spaces" is added to gateway name. Finally, in the case of the leafnode, if no cluster name is specified the server name is used, so also applying the restriction to the server name. Resolves #5633 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed behavior
When setting
server_name
to a string with a " " in it, like "My Server", results in replies not being delivered to a requestor, when the requestor lives on the hub and the replier living on a leaf node.Expected behavior
I would expect it to work as intended or throw a validation error/warning when trying to connect as a leaf node.
Server and client version
nats-server
- 2.10.17nats-cli
- (devel)main
Host environment
MacOS on M1 Mac studio for leaf node, Synadia Cloud for hub.
Steps to reproduce
server_name
of the leaf node to "My Server" (or anything with a space on it)nats reply hello.world --echo --context leaf
nats req hello.world hihi --context hub
When the
server_name
has no spaces, I don't encounter this issueThe text was updated successfully, but these errors were encountered: