Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE] made cluster_traffic a string #230

Closed
wants to merge 1 commit into from

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 26, 2024

this allows the server to do whatever it wants, while validations are casted to the ClusterTraffic string type.

…whatever it wants, while validations are casted to the `ClusterTraffic` string type.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11057920443

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 81.008%

Totals Coverage Status
Change from base Build 10906299209: 0.005%
Covered Lines: 2764
Relevant Lines: 3412

💛 - Coveralls

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is ClusterTraffic here? Subjects?

@aricart
Copy link
Member Author

aricart commented Sep 30, 2024

This is the option to enable routing for JS chatter via the system account or the user's account

@derekcollison
Copy link
Member

hmm I should know what that means but have no clue ;)

@neilalexander
Copy link
Member

It's for the account NRG, but I'm not sure why we'd want to change it into a string like this?

@aricart aricart closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants