[CHANGE] import share is now possible for stream and service exports
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the new tracing functionality this is no longer true, as I understand it anything can be traced.
Pull Request Test Coverage Report for Build 7747706204
💛 - Coveralls |
|
Closing this PR since we are no longer using "share" now for message tracing, we use allow_trace. Note that regardless of that, the original implementation was still using share only for service export/import, not for stream, so that PR would not have been needed anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharepreviously constrained to services. But with the new tracing functionality this is no longer true, as I understand it anything can be traced.