fix(android): fix crash on R emulator (fresco issue)

facebook/fresco#2049
nativescript-community · May 27, 2020 · 2a4f2b0 · 2a4f2b0
1 parent e470ea3
commit 2a4f2b0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/plugin/platforms/android/include.gradle b/plugin/platforms/android/include.gradle
@@ -2,8 +2,15 @@ android {
 }
 
 dependencies {
-	implementation 'com.facebook.fresco:fresco:2.1.0'
-	implementation 'com.facebook.fresco:animated-gif:2.1.0'
+
+
+	implementation('com.facebook.fresco:fresco:2.2.0') {
+        exclude group: 'com.facebook.soloader', module: 'soloader'
+	}
+	implementation('com.facebook.fresco:imagepipeline-okhttp3:2.2.0') {
+			exclude group: 'com.facebook.soloader', module: 'soloader'
+	}
+	implementation 'com.facebook.fresco:animated-gif:2.2.0'
     // If you want to use the GPU Filters
     // implementation 'jp.co.cyberagent.android.gpuimage:gpuimage-library:1.3.0'
 

diff --git a/src/image.android.ts b/src/image.android.ts
@@ -19,12 +19,23 @@ export function initialize(config?: ImagePipelineConfigSetting): void {
             initializeConfig = config;
             return;
         }
+        let builder = com.facebook.imagepipeline.core.ImagePipelineConfig.newBuilder(context);
         if (config && config.isDownsampleEnabled) {
-            const imagePipelineConfig = com.facebook.imagepipeline.core.ImagePipelineConfig.newBuilder(context).setDownsampleEnabled(true).build();
-            com.facebook.drawee.backends.pipeline.Fresco.initialize(context, imagePipelineConfig);
-        } else {
-            com.facebook.drawee.backends.pipeline.Fresco.initialize(context);
+            builder.setDownsampleEnabled(true);
         }
+        // builder.experiment().setNativeCodeDisabled(true);
+        const imagePipelineConfig = builder.build();
+        com.facebook.drawee.backends.pipeline.Fresco.initialize(context, imagePipelineConfig);
+        // try {
+        //     com.facebook.imagepipeline.nativecode.ImagePipelineNativeLoader.load();
+        // } catch (err) {
+        //     console.log('error loading ImagePipelineNativeLoader');
+        //     com.facebook.drawee.backends.pipeline.Fresco.shutDown();
+        //     builder.experiment().setNativeCodeDisabled(true);
+        //     const imagePipelineConfig = builder.build();
+        //     console.log('test', imagePipelineConfig.getExperiments().isNativeCodeDisabled())
+        //     com.facebook.drawee.backends.pipeline.Fresco.initialize(context, imagePipelineConfig);
+        // }
         initialized = true;
     }
 }