Enable DRPC request to be sent via HTTP and/or Thrift #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge changes from nathanmarz/storm master
merge changes from nathanmarz/storm master
merge changes from nathanmarz/storm master
| (.execute handler func args)) | ||
| (GET "/drpc/:func/" [:as {cookies :cookies} func & m] | ||
| (.execute handler func "")) | ||
| (GET "/drpc/:func" [:as {cookies :cookies} func & m] |
There was a problem hiding this comment.
I think this is in here twice by accident.
There was a problem hiding this comment.
Oops I missed the trailing '/'. Looks like jetty is not handling '/' characters very well.
|
It looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, DRPC requests could only be sent via Thrift API. We have seen various users asking for HTTP interface.
This pull request enable one to configure drpc to be sent via HTTP and/or thrift via storm.yaml:
drpc.port: <THRIFT_PORT> (default: 3772)
drpc.http.port: <HTTP_PORT> (default: unavailable)
When drpc server is started, it will look into these configuration parameters to decide whether Thrift port and/or HTTP port should be binded.
DRPC HTTP request will be received via GET via the following URI: