Improve Evenscheduler to schedule executors based supervisor used slots #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxjwind
commented
Sep 4, 2013
fxjwind
commented
- fix wrong comment
- improve the logic of sort-slots #359
|
Is this solving the problem of no allocating evenly based on currently used slots? In my case, rebalance command keeps on sending the worker to the same machine instead of the one of all free slots. |
| executor3 (WorkerSlot. "supervisor1" (int 5)) | ||
| executor4 (WorkerSlot. "supervisor2" (int 2)) | ||
| executor5 (WorkerSlot. "supervisor3" (int 11)) | ||
| executor6 (WorkerSlot. "supervisor4" (int 12)) |
There was a problem hiding this comment.
the test data here actually violates the worker number constraints, you specified the worker number to 4 for topology1, but here it is assigned 6 different workers.
|
@xumingming , thanks for your comments, have already updated |
|
@patricioe , you are right, this fix will choose supervisor with less workers(used-slots) preferentially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.