enable nimbus & UI servers to be asisgned with available port, instead of pre-configured #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This overlaps with the work done in #422 to implement HA Nimbus (it uses ZK for Nimbus discovery as part of the implementation). It would be great to get some more work done on that one (it just needs to be tested more). |
|
Do you want to merge #422 first? This new pull request is much simpler though. |
|
The HA Nimbus is far more important... and this issue would just create more work for that one. For now, for the cloud-specific use case, can't whatever's launching Nimbus find a port and configure it appropriately? That's effectively how the worker ports are configured in storm-mesos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of a series pull requests, which aim to launch Storm cluster in a cluster environment.
Currently, Nimbus server and UI server launched with a configured port number. In a cloud environment,
we don't really know which port is actually available. So, it will be convenient if Nimbus & UI server could simply
find an available port and launch it.
In this pull request, we enable Nimbus server and UI server to find ports dynamically:
Nimbus/UI server announces the port number via Zookeeper.
When Supervisor and UI server starts, they will pick up Nimbus host/port from Zookeeper (instead of simply reading configuration file).