Allow operations that look like logic vars (e.g. !count) to be used without namespace #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Nice catch. |
sritchie
added a commit
that referenced
this pull request
May 15, 2015
Allow operations that look like logic vars (e.g. !count) to be used without namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with-logic-varsaggressively rebinds logic var looking symbols to strings. This makes it impossible to use operations that start with ! or ? in the query. I have a whole library of nil-friendly operations modeled after ops/!count that doesn't work because of this. In fact, you can't use!countwithout namespace either.