Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Tribute feature (medhi ping) #4

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Tribute feature (medhi ping) #4

merged 2 commits into from
Nov 17, 2020

Conversation

valentinperignon
Copy link

@valentinperignon valentinperignon commented Nov 17, 2020

Changes:

  • One new command: ping2 answers pong et tag djolamitraille (aka "Joe the gun")

bot/strings.py Outdated
@@ -19,6 +19,9 @@ class Strings:
# Function : fun.ping()
PING = "Pong ! :ping_pong:"

# Function : fun.ping2()
PING2 = "Pong <@199621995913150464> ! :medhiblond: :ping_pong:"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work as :medhiblond: is a custom emoji. You can resolve this problem using https://discordpy.readthedocs.io/en/latest/faq.html#how-can-i-add-a-reaction-to-a-message

@nathanaelhoun nathanaelhoun added the enhancement New feature or request label Nov 17, 2020
Copy link
Owner

@nathanaelhoun nathanaelhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanaelhoun nathanaelhoun merged commit 60dfad2 into nathanaelhoun:main Nov 17, 2020
@valentinperignon
Copy link
Author

YES!

@valentinperignon valentinperignon deleted the tribute-feature branch November 17, 2020 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants