Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set DefaultValue to empty string for string[] options #540

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

natemcmaster
Copy link
Owner

Fixes #536

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #540 (fe2354a) into main (81199c7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   82.31%   82.34%   +0.02%     
==========================================
  Files         105      105              
  Lines        3303     3308       +5     
==========================================
+ Hits         2719     2724       +5     
  Misses        584      584              
Files Changed Coverage Δ
...Utils/Conventions/OptionAttributeConventionBase.cs 96.66% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@natemcmaster natemcmaster merged commit fe2354a into main Aug 26, 2023
10 checks passed
@natemcmaster natemcmaster deleted the fix/536 branch August 26, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Changes to DirectoryExists from 3.1.0 to 4.1.0
1 participant