Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete default values feature #421

Merged
merged 5 commits into from
Jan 11, 2021
Merged

Complete default values feature #421

merged 5 commits into from
Jan 11, 2021

Conversation

natemcmaster
Copy link
Owner

Closes #82

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #421 (8c2a3d2) into main (3eb90d7) will decrease coverage by 0.11%.
The diff coverage is 64.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   67.87%   67.76%   -0.12%     
==========================================
  Files         105      105              
  Lines        3175     3282     +107     
==========================================
+ Hits         2155     2224      +69     
- Misses       1020     1058      +38     
Impacted Files Coverage Δ
...neUtils/Conventions/ArgumentAttributeConvention.cs 40.74% <22.50%> (-6.76%) ⬇️
...Utils/Conventions/OptionAttributeConventionBase.cs 43.47% <41.93%> (ø)
src/CommandLineUtils/Internal/ReflectionHelper.cs 73.01% <64.28%> (-2.99%) ⬇️
src/CommandLineUtils/CommandArgument{T}.cs 96.66% <95.45%> (+5.75%) ⬆️
src/CommandLineUtils/CommandOption{T}.cs 96.66% <95.45%> (+5.75%) ⬆️
...mmandLineUtils/Abstractions/ValueParserProvider.cs 59.09% <100.00%> (-1.35%) ⬇️
src/CommandLineUtils/CommandArgument.cs 94.73% <100.00%> (+7.23%) ⬆️
src/CommandLineUtils/CommandOption.cs 69.01% <100.00%> (+1.36%) ⬆️
...mandLineUtils/HelpText/DefaultHelpTextGenerator.cs 94.73% <100.00%> (-0.54%) ⬇️
.../CommandLineUtils/Internal/CommandLineProcessor.cs 83.04% <100.00%> (+0.43%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb90d7...8c2a3d2. Read the comment docs.

@natemcmaster natemcmaster merged commit 1524f56 into main Jan 11, 2021
@natemcmaster natemcmaster deleted the feature/default-value branch January 11, 2021 01:32
@natemcmaster natemcmaster added this to the 4.0.0 milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: provide default value for option (and show it in the help)
2 participants