Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show allowed values from AllowedValues attribute instead of Enum #391

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

scott-xu
Copy link
Contributor

For example, when use HashAlgorithmType as the option type, we want to limit the values to Sha256, Sha384 and Sha512.
Prior to the fix, there will be 2 lines of "Default values are: ..." in help text.

…lues

for eample, when use `HashAlgorithmType` https://docs.microsoft.com/en-us/dotnet/api/system.security.authentication.hashalgorithmtype?view=netframework-4.8 as the option type, we want to limit the values to Sha256, Sha384 and Sha512.
Prior the fix, there will be 2 lines of "Default values are: ..." in help text
Copy link
Owner

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@natemcmaster natemcmaster merged commit 569b913 into natemcmaster:main Sep 12, 2020
@natemcmaster natemcmaster added this to the 3.1.0 milestone Sep 12, 2020
@scott-xu scott-xu deleted the allowed-values-for-enum branch September 12, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants