Dynamically wrap argument and option descriptions based on console width in the default help text generator.

[kyle-rader]

Dynamic description wrapping in generated help text

This addresses my two concerns in issue #246.

New Behavior

• Now, description lines will dynamically wrap with a padded newline at the current console width.
• Explicit newlines in the descriptions will be preserved still, but now in a cross platform friendly way: either \n or \r\n will result in a padded newline.

[natemcmaster]

Hey there, just letting you know I've seen this, but haven't reviewed it. I'm on vacation for 2 more weeks without a laptop, and I'll take a closer look when I'm home.

[kyle-rader]

Cheers Mate!

…

On Mon, Jul 1, 2019, 7:14 AM Nate McMaster ***@***.***> wrote: Hey there, just letting you know I've seen this, but haven't reviewed it. I'm on vacation for 2 more weeks without a laptop, and I'll take a closer look when I'm home. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#248?email_source=notifications&email_token=ABEI7XDDEJZU54NPNBSXWUDP5IGNDA5CNFSM4H4AWLR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY6ILHA#issuecomment-507282844>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABEI7XDLFYVFCBBJRAU2XK3P5IGNDANCNFSM4H4AWLRQ> .

[natemcmaster]

Thanks for the PR! This one is particularly well done. I'm glad to see you have added tests, removed some duplicated code, and documented all new API.

I have a few suggestions on how I'd like to tweak this change before merging. What you have appears to be fully functional already, so if you don't have time to update your PR, I can merge and make the changes myself. Let me know either way!

Thanks,
Nate

[kyle-rader]

@natemcmaster acking - will take a look tonight again Thanks for making the HelpTextGenerator extendable. I added this functionality into our app a few weeks ago that way.

[kyle-rader]

@natemcmaster Great suggestions, thanks for the review. I've resolved all comments.

[kyle-rader]

I've also rebased onto master.

[natemcmaster]

Looks great! Thanks for updating with my feedback. This will be in the 2.4.0 RC release, which I'm hoping to release in a few weeks.