Skip to content

Commit

Permalink
cleanup: fixup more references to 'master'
Browse files Browse the repository at this point in the history
  • Loading branch information
natemcmaster committed Nov 30, 2020
1 parent 7d705cc commit df0a511
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-reportgenerator-globaltool": {
"version": "4.7.1",
"version": "4.8.1",
"commands": [
"reportgenerator"
]
Expand Down
2 changes: 1 addition & 1 deletion src/CommandLineUtils/releasenotes.props
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Bugs fixed:
</PackageReleaseNotes>
<PackageReleaseNotes>$(PackageReleaseNotes)

See more details here: https://github.com/natemcmaster/CommandLineUtils/blob/master/CHANGELOG.md#v$(VersionPrefix.Replace('.',''))
See more details here: https://github.com/natemcmaster/CommandLineUtils/blob/main/CHANGELOG.md#v$(VersionPrefix.Replace('.',''))
</PackageReleaseNotes>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion src/Hosting.CommandLine/releasenotes.props
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ $(PackageReleaseNotes)
</PackageReleaseNotes>
<PackageReleaseNotes>$(PackageReleaseNotes)

See more details here: https://github.com/natemcmaster/CommandLineUtils/blob/master/CHANGELOG.md#v$(VersionPrefix.Replace('.',''))
See more details here: https://github.com/natemcmaster/CommandLineUtils/blob/main/CHANGELOG.md#v$(VersionPrefix.Replace('.',''))
</PackageReleaseNotes>
</PropertyGroup>
</Project>
30 changes: 15 additions & 15 deletions test/CommandLineUtils.Tests/SubcommandAttributeTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ public void AddsSubcommands()
rm => { Assert.Equal("rm", rm.Name); });
}

[Command(Name = "master")]
[Command(Name = "top")]
[Subcommand(typeof(Level1Command))]
private class MasterApp : CommandBase
private class TopApp : CommandBase
{
[Option(Inherited = true)]
public bool Verbose { get; set; }
Expand All @@ -66,7 +66,7 @@ private class Level1Command : CommandBase

protected override int OnExecute(CommandLineApplication app) => 101;

public MasterApp? Parent { get; }
public TopApp? Parent { get; }
}

private class Level2Command : CommandBase
Expand All @@ -93,25 +93,25 @@ abstract class CommandBase
[Fact]
public void ItInvokesExecuteOnSubcommand_Bottom()
{
var rc = CommandLineApplication.Execute<MasterApp>(new TestConsole(_output), "level1", "level2", "--value",
var rc = CommandLineApplication.Execute<TopApp>(new TestConsole(_output), "level1", "level2", "--value",
"6");
Assert.Equal(6, rc);

rc = CommandLineApplication.Execute<MasterApp>(new TestConsole(_output), "level1", "level2");
rc = CommandLineApplication.Execute<TopApp>(new TestConsole(_output), "level1", "level2");
Assert.Equal(102, rc);
}

[Fact]
public void ItInvokesExecuteOnSubcommand_Middle()
{
var rc = CommandLineApplication.Execute<MasterApp>(new TestConsole(_output), "level1");
var rc = CommandLineApplication.Execute<TopApp>(new TestConsole(_output), "level1");
Assert.Equal(101, rc);
}

[Fact]
public void ItInvokesExecuteOnSubcommand_Top()
{
var rc = CommandLineApplication.Execute<MasterApp>(new TestConsole(_output));
var rc = CommandLineApplication.Execute<TopApp>(new TestConsole(_output));
Assert.Equal(100, rc);
}

Expand All @@ -124,9 +124,9 @@ public void HandlesHelp_Bottom()
{
Out = output,
};
var rc = CommandLineApplication.Execute<MasterApp>(console, "level1", "level2", "--help");
var rc = CommandLineApplication.Execute<TopApp>(console, "level1", "level2", "--help");
Assert.Equal(0, rc);
Assert.Contains("Usage: master level1 level2 [options]", sb.ToString());
Assert.Contains("Usage: top level1 level2 [options]", sb.ToString());
}

[Fact]
Expand All @@ -138,9 +138,9 @@ public void HandlesHelp_Middle()
{
Out = output,
};
var rc = CommandLineApplication.Execute<MasterApp>(console, "level1", "--help");
var rc = CommandLineApplication.Execute<TopApp>(console, "level1", "--help");
Assert.Equal(0, rc);
Assert.Contains("Usage: master level1 [command] [options]", sb.ToString());
Assert.Contains("Usage: top level1 [command] [options]", sb.ToString());
}

[Fact]
Expand All @@ -152,15 +152,15 @@ public void HandlesHelp_Top()
{
Out = output,
};
var rc = CommandLineApplication.Execute<MasterApp>(console, "--help");
var rc = CommandLineApplication.Execute<TopApp>(console, "--help");
Assert.Equal(0, rc);
Assert.Contains("Usage: master [command] [options]", sb.ToString());
Assert.Contains("Usage: top [command] [options]", sb.ToString());
}

[Fact]
public void ItCreatesNestedSubCommands()
{
var app = new CommandLineApplication<MasterApp>();
var app = new CommandLineApplication<TopApp>();
app.Conventions.UseSubcommandAttributes().UseCommandAttribute().UseCommandNameFromModelType();
var lvl1 = Assert.Single(app.Commands);
Assert.Equal("level1", lvl1.Name);
Expand All @@ -171,7 +171,7 @@ public void ItCreatesNestedSubCommands()
[Fact]
public void ItBindsOptionsOnParentItems()
{
var app = CommandLineParser.ParseArgs<MasterApp>("level1", "--mid", "level2", "--verbose", "--value", "6");
var app = CommandLineParser.ParseArgs<TopApp>("level1", "--mid", "level2", "--verbose", "--value", "6");
Assert.IsType<Level1Command>(app.Subcommand);
var sub = Assert.IsType<Level2Command>(app.Subcommand?.Subcommand);
Assert.NotNull(sub.Parent);
Expand Down

0 comments on commit df0a511

Please sign in to comment.