UsePagerForHelpText property is inherited (#237)

* UsePagerForHelpText property is inherited * Remove redundant config from the test
natemcmaster · May 24, 2019 · 08c6764 · 08c6764
1 parent e6e0a36
commit 08c6764
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/CommandLineUtils/CommandLineApplication.cs b/src/CommandLineUtils/CommandLineApplication.cs
@@ -105,6 +105,7 @@ internal CommandLineApplication(CommandLineApplication parent,
             _services = new Lazy<IServiceProvider>(() => new ServiceProvider(this));
             ValueParsers = parent?.ValueParsers ?? new ValueParserProvider();
             _clusterOptions = parent?._clusterOptions;
+            UsePagerForHelpText = parent?.UsePagerForHelpText ?? true;
 
             _conventionContext = CreateConventionContext();
 
@@ -172,7 +173,7 @@ public string Name
         /// <summary>
         /// Whether a Pager should be used to display help text.
         /// </summary>
-        public bool UsePagerForHelpText { get; set; } = true;
+        public bool UsePagerForHelpText { get; set; }
 
         /// <summary>
         /// All names by which the command can be referenced. This includes <see cref="Name"/> and an aliases added in <see cref="AddName"/>.

diff --git a/test/CommandLineUtils.Tests/CommandLineApplicationTests.cs b/test/CommandLineUtils.Tests/CommandLineApplicationTests.cs
@@ -786,6 +786,16 @@ public void InheritedHelpOptionCanBeOverridden()
             Assert.NotSame(help, sub2.OptionHelp);
         }
 
+        [Theory]
+        [InlineData(false)]
+        [InlineData(true)]
+        public void UsePagerForHelpTextPropertyIsInherited(bool usePagerForHelpText)
+        {
+            var app = new CommandLineApplication { UsePagerForHelpText = usePagerForHelpText };
+            var sub = app.Command("sub", _ => { });
+            Assert.Equal(usePagerForHelpText, sub.UsePagerForHelpText);
+        }
+
         [Fact]
         public void VersionOptionIsSet()
         {