Skip to content

Commit

Permalink
Merge pull request #2259 from herwinw/time_to_date
Browse files Browse the repository at this point in the history
Implement Time#to_date
  • Loading branch information
herwinw committed Oct 11, 2024
2 parents 1c9ce4f + acbd405 commit 41d91e8
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 0 deletions.
9 changes: 9 additions & 0 deletions lib/time.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# frozen_string_literal: true

class Time
def to_date
require 'date'

Date.new(year, month, mday)
end
end
48 changes: 48 additions & 0 deletions spec/library/date/time/to_date_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@

require_relative '../../../spec_helper'
require 'time'

describe "Time#to_date" do
it "yields accurate julian date for ambiguous pre-Gregorian reform value" do
NATFIXME 'yields accurate julian date for ambiguous pre-Gregorian reform value', exception: SpecFailedException do
Time.utc(1582, 10, 4).to_date.jd.should == Date::ITALY - 11 # 2299150j
end
end

it "yields accurate julian date for Julian-Gregorian gap value" do
NATFIXME 'yields accurate julian date for Julian-Gregorian gap value', exception: Date::Error, message: 'invalid date' do
Time.utc(1582, 10, 14).to_date.jd.should == Date::ITALY - 1 # 2299160j
end
end

it "yields accurate julian date for post-Gregorian reform value" do
Time.utc(1582, 10, 15).to_date.jd.should == Date::ITALY # 2299161j
end

it "yields same julian day regardless of UTC time value" do
Time.utc(1582, 10, 15, 00, 00, 00).to_date.jd.should == Date::ITALY
Time.utc(1582, 10, 15, 23, 59, 59).to_date.jd.should == Date::ITALY
end

it "yields same julian day regardless of local time or zone" do

with_timezone("Pacific/Pago_Pago", -11) do
Time.local(1582, 10, 15, 00, 00, 00).to_date.jd.should == Date::ITALY
Time.local(1582, 10, 15, 23, 59, 59).to_date.jd.should == Date::ITALY
end

with_timezone("Asia/Kamchatka", +12) do
Time.local(1582, 10, 15, 00, 00, 00).to_date.jd.should == Date::ITALY
Time.local(1582, 10, 15, 23, 59, 59).to_date.jd.should == Date::ITALY
end

end

it "yields date with default Calendar reform day" do
Time.utc(1582, 10, 4).to_date.start.should == Date::ITALY
NATFIXME 'yields date with default Calendar reform day', exception: Date::Error, message: 'invalid date' do
Time.utc(1582, 10, 14).to_date.start.should == Date::ITALY
end
Time.utc(1582, 10, 15).to_date.start.should == Date::ITALY
end
end

0 comments on commit 41d91e8

Please sign in to comment.