Infinite loop if initialization fails for any reason

[jphickey]

Describe the bug
SCH_LAB does not exit/abort if its initialization fails - it will continue into its main loop anyway. In turn, it is possible that the "CmdPipe" was not initialized when this task calls CFE_SB_ReceiveBuffer. This will return an error, but it just repeats the loop, forever.

To Reproduce
Delete or do not install the SCH LAB table file, so the loading of the table will fail. SCH_LAB then enters an infinite loop, because the CmdPipe is not valid, continually generating this error event:

EVS Port1 42/1/CFE_SB 19: Rcv Err:PipeId 0 does not exist,app SCH_LAB_APP

Expected behavior
If it did not successfully initialize itself, SCH LAB should skip the remainder of its main function, since behavior is non-deterministic if not fully and successfully initialized.

Code snips
The "while" loop here should probably be moved to an "else" block, so it will only be entered if initialized successfully.

sch_lab/fsw/src/sch_lab_app.c

Lines 91 to 97 in 4a1b72e

	if (Status != CFE_SUCCESS)
	{
	CFE_ES_WriteToSysLog("SCH_LAB: Error Initializing RC = 0x%08lX\n", (unsigned long)Status);
	}
	/* Loop Forever */
	while (CFE_ES_RunLoop(&RunStatus) == true)

System observed on:
Ubuntu

Reporter Info
Joseph Hickey, Vantage Systems, Inc.