Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #19, Update coverage compile/link flag options #20

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix #19, Update coverage compile/link flag options #20

merged 1 commit into from
Apr 28, 2020

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Apr 14, 2020 •
edited
Loading

Describe the contribution

OSAL now sets these as UT_COVERAGE_COMPILE_FLAGS, UT_COVERAGE_LINK_FLAGS.
Building and linking the UT executable needs a corresponding update.

Fixes #19

Testing performed
Build with ENABLE_UNIT_TESTS=TRUE and confirm that all unit tests are building

Expected behavior changes
Coverage data (make lcov) now includes the sample_lib code again

System(s) tested on
Ubuntu 18.04 LTS 64 bit

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Fix nasa#19, Update coverage compile/link flag options
78edacf 
OSAL now sets these as UT_COVERAGE_COMPILE_FLAGS, UT_COVERAGE_LINK_FLAGS.
Building and linking the UT executable needs a corresponding update.
@jphickey jphickey mentioned this pull request Apr 14, 2020
Merged
@skliper skliper added the CCB:Ready PR or Issue is ready for discussion at the Configuration Control Board (CCB) label Apr 15, 2020
@skliper
Copy link
Contributor

skliper commented Apr 22, 2020

20200422 CCB - APPROVED

@skliper skliper added bug Something isn't working CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready PR or Issue is ready for discussion at the Configuration Control Board (CCB) labels Apr 22, 2020
@skliper skliper added this to the 1.2.0 milestone Apr 22, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 27, 2020 22:59
@astrogeco astrogeco merged commit b93753b into nasa:integration-candidate Apr 28, 2020
@astrogeco astrogeco mentioned this pull request May 1, 2020
Merged
@jphickey jphickey deleted the fix-19-ut-coverage-flags branch June 8, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Unit tests need to link with UT_COVERAGE_COMPILE_FLAGS/UT_COVERAGE_LINK_FLAGS
3 participants
@jphickey @skliper @astrogeco