Fix #87, Unit test MID string format now 32bit

[skliper]

Describe the contribution
Fix #87
With nasa/cFE#880, the format is now consistently 32 bit, fixed event string check to match.

Testing performed
Built unit tests with nasa/cFE#880, now passes

Expected behavior changes
Unit test pass

System(s) tested on

• Hardware: cFS Dev server
• OS: Ubuntu 18.04
• Versions: Bundle main + Fix #796, Remove dependency on CCSDS version define cFE#880 + this commit

Additional context
None.

Third party code
None.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

[yammajamma]

CCB 2020-09-16 APPROVED

[jphickey]

While this appears to fix the case where v2 headers are used, it breaks v1 headers, where MID remains 0xFFFF not 0xFFFFFFFF.

This is precisely why my original comment regarding checking full event text says its a bad idea to do.
I still recommend to check only the format code, not full text.

[astrogeco]

While this appears to fix the case where v2 headers are used, it breaks v1 headers, where MID remains 0xFFFF not 0xFFFFFFFF.

This is precisely why my original comment regarding checking full event text says its a bad idea to do.
I still recommend to check only the format code, not full text.

should we revert this merge then?

[jphickey]

should we revert this merge then?

See my recommended fix in #99. I pushed as a PR rather than a hotfix commit as it probably warrants a review, but IMO this is what we should have done in the first place.

[astrogeco]

#99 looks like it needs some CCB insight or at least have a review by @skliper. I vote for reverting this so we don't "slow the train down" a second option would be to move forward with the rest of the IC despite it not passing some unit tests.

[jphickey]

I'd vote to revert, rather than have a broken build, if you don't want to fast track #99.

[skliper]

While this appears to fix the case where v2 headers are used, it breaks v1 headers, where MID remains 0xFFFF not 0xFFFFFFFF.

This is precisely why my original comment regarding checking full event text says its a bad idea to do.
I still recommend to check only the format code, not full text.

So this change works with nasa/cFE#880, such that it's always 0xFFFFFFFF, as stated in the description. Shouldn't be a broken build, no need to revert, just merge that change also? Although as an example, I'm fine with whatever fix people want to go with (#99 or whatever). This was just a simple update such that nasa/cFE#880 wouldn't break the build.

[jphickey]

Sorry, I didn't notice how nasa/cFE#880 was missed ... But we can do both. They are both still relevant anyway.

I'd like to update sample_app to do format strings only, so it only changes whether it is a hotfix to make UT pass again or if it is just a normal update. There are just too many ways to get into trouble with full text compares. This should make all the event checking more future proof.