OSAL Integration Candidate: 2020-12-22 #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all definitions and instantiations out of the header file. Reuse the single task definition that was already defined. Also only define 3 instances of each type, as this is all that the test actually uses (no need for 20).
This adds support for vxworks7 with its minor differences from vxworks6.
Includes compatibility wrappers for the old header names. Refactors inclusions in all OSAL source files to only include the components they actually use/refer to. Refactor all inclusion guards to follow the same general format (uppercase filename, no leading/trailing underscore)
Removes the signal mask updates from the POSIX global lock (not needed). Adds a condition variable to the structure, which can be used to directly wake up a waiting task rather than requiring that task to poll the global state.
Fix #410, breakup includes
|
@jphickey this is failing with OMIT_DEPRECATED, see https://github.com/nasa/cFS/pull/162/checks?check_run_id=1552281978. Was there a dependency I missed in #675 ? |
|
Merged nasa/cFE#1043 which I think will fix this |
Confirmed - nasa/cFE#1043 that you already found was the correct/intended fix for this dependency. |
Add macros for configurable behavior of argument bug checking. - BUGCHECK for checking argument values which should never happen and indicate bugs if they do. - ARGCHECK for checking argument values which may happen and can be mitigated if they do. The behavior of BUGCHECK is influenced by two new OSAL config options, which can disable it completely or make it strict/enforcing such that it will abort() for debugging if a condition is not met.
Use the new macros to validate arguments to OS API calls. Also includes coverage test updates, which revealed some areas where return types were not consistent, and the macro makes them consistent now.
astrogeco
changed the title
Fix #610, Add vxworks7 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Combines IC-2020-12-15 and 2020-12-22
Fix #377 Add "OSAL Select" functional tests
Fix #410, breakup OSAL includes
Fix #542, Avoid UT failure if SEM_VALUE_MAX >= UINT32_MAX
Fix #569, Check and report sysconf error return
Fix #610, Add vxworks 7 support
Fix #670, clean up task definitions in core test
Fix #673 #677, improve global lock on POSIX
Fix #679, Convert OSAL Config Guide to markdown
Fix #686, Use errno in clock_getres error reporting
Fix #688, Implement macro to facilitate argument checking
Testing performed
See https://github.com/nasa/cFS/pull/162/checks
Expected behavior changes
PR #659 - Convert the OSAL Configuration Guide from docx and pdf to a markdown file.
PR #671 - Test Tasks do not run at 100%. Move all definitions and instantiations out of the core-test header file and reuse the already-existing single task definition.
PR #675 - Break up
osapi-os-*.hfiles into units that correspond to the implementation units. Kept old header file names for compatibility.PR #678 - Reworks the POSIX global lock implementation. Does not change the POSIX signal mask when locking/unlocking the global.
PR #682 - Checks return of sysconf for error and reports them. Only sets PageSize on success. If sysconf fails it provides a mechanism to avoid error propagation.
PR #687 - Uses
errnoinstead of status return fromclock_getreswithstrerrorreporting.PR #599 - Adds support for VxWorks 7
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#162
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@skliper
@zanzaben
@ArielSAdamsNASA