Fix #623, add debug messages for mutex double locks #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if OS_DEBUG is enabled, this adds a message if mutex give/take actions occur outside the expected sequence. In particular, this warns if a task takes a mutex more than once.
jphickey
added
the
CCB:Ready
zanzaben
approved these changes
Oct 28, 2020
astrogeco
removed
the
CCB:Ready
|
CCB 2020-10-28 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#632, Infer OSAL_SYSTEM_BSPTYPE from CFE_SYSTEM_PSP_NAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
If
OS_DEBUGis enabled, this adds a message if mutex give/take actions occur outside the expected sequence. In particular,this warns if a task takes a mutex more than once.
Fixes #623
Testing performed
Build and sanity test CFE with debug events enabled, confirm normal boot and operation.
Send "remove packet" request to TO_LAB.
Confirm warning is generated as follows (this is a known issue in CFE doing multiple locks):
Expected behavior changes
If debugging is enabled this now informs the user (via the debug console) if a lock is taken more than once.
It will also warn if a lock is given by a different task than what originally took it.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.