Fix #615, RTEMS build issues #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct issues involving recent OS_Milli2Ticks change. Note - for OS_TaskDelay it is important that this doesn't degrade into a no-op. So if OS_Milli2Ticks fails here, this returns the error but still also does a non-zero delay.
|
Suggesting fast-track as the |
jphickey
added
the
CCB:Ready
|
@acudmore can you take a look? |
skliper
approved these changes
Oct 2, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Oct 5, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Oct 6, 2020
Combines - nasa/cFE#936 - nasa/osal#612 *** * Add osal#541 * Add cfe#898 * Add cfe#925 * Add cfe#917 * Add cFE#899 * Add nasa/cFE#888 * Add CFE hotfix for documentation link warnings * Add FastTracked nasa/osal#616 * Set submodules to main for IC-2020-10-07 Co-authored-by: Joseph Hickey <joseph.p.hickey@nasa.gov>
This was referenced Oct 6, 2020
astrogeco
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Correct issues involving recent OS_Milli2Ticks change.
Note - for OS_TaskDelay it is important that this doesn't degrade into a no-op. So if OS_Milli2Ticks fails here, this returns the
error but still also does a non-zero delay.
Testing performed
Build and sanity check CFE under RTEMS
Run all unit tests
Expected behavior changes
Builds and runs correctly
System(s) tested on
RTEMS 4.11.3 + pc686 BSP target (QEMU) using Ubuntu 20.04 build host
Additional context
Includes the typo fix in #614 plus others.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.