Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #565, propagate return code from OS_TaskRegister_Impl() #566

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
If this routine fails then return the error to the caller, which will also prevent the task from starting.

Fixes #565

Testing performed
Build and sanity check CFE
Build and run all unit tests incl. coverage.

Expected behavior changes
No impact to behavior, as no known way to force this error, but will correctly propagate an error if one were to occur.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

If this routine fails then return the error to the caller,
which will also prevent the task from starting.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 18, 2020
@astrogeco
Copy link
Contributor

CCB 2020-08-19 APPROVED

@yammajamma yammajamma changed the base branch from main to integration-candidate August 20, 2020 14:43
@yammajamma yammajamma added CCB:Approved Indicates code review and approval by community CCB IC-20200819 labels Aug 20, 2020
@yammajamma yammajamma merged commit 8648e9c into nasa:integration-candidate Aug 20, 2020
@yammajamma yammajamma removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 20, 2020
@skliper skliper added this to the 6.0.0 milestone Aug 21, 2020
@jphickey jphickey deleted the fix-565-taskprepare-return branch December 3, 2020 17:26
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS_TaskPrepare should propagate return code.
4 participants