Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #307, Remove unsupported BSPs #311

Merged
merged 1 commit into from
Dec 30, 2019
Merged

issue #307, Remove unsupported BSPs #311

merged 1 commit into from
Dec 30, 2019

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Dec 12, 2019

Describe the contribution
Remove unsupported BSP and change genppc-vxworks6.4→ mcp750-vxworks

System(s) tested on:

  • Hardware
  • Ubuntu 18.04

Contributor Info
Anh Van, NASA Goddard

@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Dec 18, 2019
@skliper skliper added this to the 5.1.0 milestone Dec 18, 2019
@skliper
Copy link
Contributor

skliper commented Dec 18, 2019

CCB 20191218 - Reviewed and approved for IC

@jphickey
Copy link
Contributor

NOTE: the old name of the BSP is referenced in the CFE example toolchains here:

https://github.com/nasa/cFE/blob/2b27dfc8f2a4e0627e6c4b646765269213584cda/cmake/sample_defs/toolchain-ppc-vxworks6.9.cmake#L49

This external reference also needs to be updated accordingly.

skliper
skliper requested changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Joe's comment (update example toolchain file) as part of this update.

@avan989
Copy link
Contributor Author

avan989 commented Dec 23, 2019

updated. Reference nasa/cFE#444

@avan989 avan989 mentioned this pull request Dec 23, 2019
Merged
@skliper skliper merged commit 1ce7086 into nasa:master Dec 30, 2019
@skliper
Copy link
Contributor

skliper commented Dec 30, 2019

Merged to master prematurely, reverted and merged to ic branch.

skliper added a commit that referenced this pull request Dec 30, 2019
@skliper
CCB 20191218: Merge #296 #299 #306 #310 #311 #315 #317 #318 #322 #324
9e3027f 
Fix #295, #298, #305, #307, #308,
    #313, #314, #316, #321, #323
Reviewed and approved at 2019-12-18 CCB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.
3 participants
@avan989 @skliper @jphickey