Fix #266: Rename "vxworks-ng" and "posix-ng" coverage tests #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
approved these changes
Oct 18, 2019
Rename to "vxworks" and "posix", respectively, to match the actual implementation names. The build scripts rely on the name being the same and will fail if different. This also updates the default build to be vxworks rather than vxworks6, if not specified on the command line.
jphickey
force-pushed
the
fix-266-coverage-rename
branch
from
4eb6848
to
89fec29
Compare
|
Commit Updated to address one minor detail - the default coverage implementation if not specified on the command line was still referring to vxworks6 here. Commit 89fec29 fixes the default to be vxworks instead. |
skliper
approved these changes
Oct 21, 2019
This was referenced Oct 22, 2019
skliper
added
the
CCB:Approved
|
CCB 20191023 - reviewed and approved |
skliper
added a commit
that referenced
this pull request
Oct 31, 2019
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Documentation/comment only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename to "vxworks" and "posix", respectively, to match the
actual implementation names. The build scripts rely on
the name being the same and will fail if different.
Fixes issue #266
Testing performed
Build coverage test for vxworks using cmake command:
cmake -DOSALCOVERAGE_TARGET_OSTYPE='shared;vxworks' -DOSAL_INCLUDEDIR=$CONFIG_DIR $OSAL_DIR/src/unit-test-coverageFollowed by "make" as usual.
Expected behavior changes
The build completes successfully.
System(s) tested on:
Ubuntu 18.04.2 64-bit
Additional context
This only fixes the specific issue of the name mismatches and subsequent build failure. There are a couple other issue tickets about coverage testing which this does not address. These will be addressed in other commits/pull requests.
Contributor Info
Joseph Hickey, Vantage Systems, Inc.