-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1417, Fix #1418, Fix workflow bug and enforce updating of coverage minimums #1419
Merged
dzbaker
merged 1 commit into
nasa:main
from
thnkslprpt:fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating
Aug 22, 2024
Merged
Fix #1417, Fix #1418, Fix workflow bug and enforce updating of coverage minimums #1419
dzbaker
merged 1 commit into
nasa:main
from
thnkslprpt:fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating
branch
from
March 23, 2024 11:16
d449b9c
to
2fba676
Compare
skliper
approved these changes
Aug 8, 2024
skliper
added
the
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
label
Aug 8, 2024
thnkslprpt
force-pushed
the
fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating
branch
from
August 8, 2024 17:42
2fba676
to
471a3a4
Compare
dzbaker
added
CCB:Approved
Indicates code review and approval by community CCB
and removed
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Aug 8, 2024
thnkslprpt
force-pushed
the
fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating
branch
from
August 8, 2024 18:45
d99bff7
to
d95c5f6
Compare
FYI @dzbaker I rebased this to main and updated it to make the plural/singular wording automatic. |
Thanks! |
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 16, 2024
*Combines:* cFE equuleus-rc1+dev187 osal equuleus-rc1+dev85 PSP equuleus-rc1+dev48 **Includes:** *cFE* - nasa/cFE#2591 *osal* - nasa/osal#1419 *PSP* - nasa/PSP#436 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jose Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Aug 16, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 22, 2024
*Combines:* cFE equuleus-rc1+dev187 osal equuleus-rc1+dev85 **Includes:** *cFE* - nasa/cFE#2591 *osal* - nasa/osal#1419 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jose Martinez Pedraza <pepepr08@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 22, 2024
*Combines:* cFE equuleus-rc1+dev187 osal equuleus-rc1+dev85 **Includes:** *cFE* - nasa/cFE#2591 *osal* - nasa/osal#1419 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Jose Martinez Pedraza <pepepr08@users.noreply.github.com>
thnkslprpt
deleted the
fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating
branch
August 23, 2024 05:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
env.run_lcov == 'TRUE'
, which is what triggers the 'Check Coverage' step to run)Testing performed
Tested all variations of coverage thresholds (above, below, split between functions/lines/branches etc.) to confirm expected behavior.
New checks:
Expected behavior changes
Any PR that improves coverage will cause the workflow to fail now unless the
allowed_ncov_lines
,allowed_ncov_branches
and/orallowed_ncov_functions
variables are updated as part of the same PR.System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt