Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osal Integration candidate: 2021-08-24 #1132

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Aug 19, 2021

Describe the contribution

PR #1131

Fix #1130, add test case types similar to NA

Testing performed
osal CI https://github.com/nasa/osal/pull/1132/checks
cFS Bundle CI https://github.com/nasa/cFS/pull/340/checks

Expected behavior changes
See PR

System(s) tested on
Ubuntu

Additional context
Part of nasa/cFS#340

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey

jphickey and others added 2 commits August 18, 2021 16:24
Add two more test case variants, similar to NA, where failure
of the test case does not translate to failure of the overall
test:

 - UTASSERT_CASETYPE_WARN
 - UTASSERT_CASETYPE_FLOW

The additional cases have different levels of default visibility,
and may be handled differently by the end user.  That is, some
tests may be skipped because they are truly NA (and nothing for
the user to do to change that) and some tests may be skipped
because the system was not set up in a way that allowed them
to be run (and the user must fix that and re-run).  For the
latter case, the WARN type can be used, to more clearly
indicate it is an action item for the user.

Lastly the "FLOW" message is intended to indicate internal decisions
in the test case implementation (not actual test cases).
@astrogeco astrogeco marked this pull request as draft August 19, 2021 13:51
@astrogeco astrogeco changed the title osal Integration candidate: 2021-08-19 osal Integration candidate: 2021-08-24 Aug 19, 2021
@astrogeco astrogeco marked this pull request as ready for review August 20, 2021 23:25
@astrogeco astrogeco merged commit 2cd118e into main Aug 21, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UtAssert "N/A" test case type is slightly overloaded
3 participants