Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remaining loops through all objects with iterators #702

Closed
jphickey opened this issue Dec 21, 2020 · 0 comments · Fixed by #704 or #750
Closed

Replace remaining loops through all objects with iterators #702

jphickey opened this issue Dec 21, 2020 · 0 comments · Fixed by #704 or #750
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Previous changes introduced the concept of an iterator in the OSAL shared layer to iterate across all objects of a particular type. However there remains a few cases where code is still doing a "for" loop through each index.

Describe the solution you'd like
For consistency of operation, these should be converted to iterators.

Additional context
Importantly the iterator handles locking of the global table. Using the iterator ensures that this is done consistently, and provides the appropriate token object for any calls to other functions.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Dec 21, 2020
jphickey added a commit to jphickey/osal that referenced this issue Dec 22, 2020
Convert remaining operations using for loops to use iterators.
This ensures locking is done consistently and correctly.
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants