Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem using wrong length for device_name field #455

Closed
jphickey opened this issue May 13, 2020 · 1 comment · Fixed by #464 or #482
Closed

Filesystem using wrong length for device_name field #455

jphickey opened this issue May 13, 2020 · 1 comment · Fixed by #464 or #482
Assignees
Labels
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The device_name field within the OS_filesys_internal_record_t is using a length of OS_MAX_API_NAME, which is not correct/ideal.

Describe the solution you'd like
The length should be OS_FS_DEV_NAME_LEN

Additional context
This is an existing symbol defined in the osapi-os-filesys.h public API header file. Noted when working on BSP volume table removal.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this May 13, 2020
@jphickey
Copy link
Contributor Author

Calling this an enhancement not a bug because the length is checked OK, no risk of buffer overrun or other badness, just smaller than what it should be.

jphickey added a commit to jphickey/osal that referenced this issue May 14, 2020
This string should be of OS_FS_DEV_NAME_LEN
astrogeco added a commit that referenced this issue May 26, 2020
Fix #455, correct length of device_name in filesys
@astrogeco astrogeco added this to the v5.1.0 milestone Sep 28, 2020
@astrogeco astrogeco added bug and removed enhancement labels Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants