Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS_IntGetMask OS_IntSetMask missing functional tests #376

Closed
skliper opened this issue Mar 23, 2020 · 4 comments
Closed

OS_IntGetMask OS_IntSetMask missing functional tests #376

skliper opened this issue Mar 23, 2020 · 4 comments
Labels

Comments

@skliper
Copy link
Contributor

skliper commented Mar 23, 2020

Is your feature request related to a problem? Please describe.
Missing functional tests for OS_IntGetMask and OS_IntSetMask

Describe the solution you'd like
Add tests

Describe alternatives you've considered
None

Additional context
Certification issue

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 5.1.0 milestone Mar 23, 2020
@jphickey
Copy link
Contributor

Not so sure how these can be tested in a functional test as the definition of an interrupt mask is CPU/BSP-specific. While OSAL might have a wrapper around the syscall it doesn't really abstract the semantics of it. Furthermore, the side effects are likely quite different on a multi-core CPU.

Recommend to deprecate the functions, like the FPU variants. I don't see either of these calls being used by any current CFE/PSP code. POSIX and RTEMS both return OS_ERR_NOT_IMPLEMENTED for these anyway.

@skliper
Copy link
Contributor Author

skliper commented Mar 23, 2020

@acudmore opinion? I'm all for deprecation.

@skliper
Copy link
Contributor Author

skliper commented Mar 25, 2020

#71 also related (and highlights issue of platform dependence).

@skliper skliper removed this from the 5.1.0 milestone Mar 26, 2020
@skliper
Copy link
Contributor Author

skliper commented Mar 26, 2020

#396 makes this no longer applicable

@skliper skliper closed this as completed Mar 26, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fixes nasa#361, nasa#373, nasa#374, nasa#381
Code reviewed and approved at 20191023 and 30 CCBs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants